Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: yarn v1 dependency tree was incomplete #1162

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Jun 11, 2024

For the attached yarn v1 lock file, the dependency tree was incomplete in two scenarios:

  1. Presence of optional dependencies
  2. Use of space in the version range

Components list was unaffected.

Example: nomnom is no longer missed due to the space nomnom ">= 1.5.x"

{
      "ref": "pkg:npm/jsonlint@1.6.2",
      "dependsOn": [
        "pkg:npm/JSV@4.0.2",
        "pkg:npm/nomnom@1.8.1"
      ]
}

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu requested a review from setchy as a code owner June 11, 2024 15:27
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Copy link
Collaborator Author

prabhu commented Jun 11, 2024

@cerrussell should we update the snapshots for this?

@prabhu prabhu merged commit c61b776 into master Jun 11, 2024
24 checks passed
@prabhu prabhu deleted the fix/yarnv1-fs branch June 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant