Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional TFM do STJ can be eliminated #282

Closed
thompson-tomo opened this issue Apr 5, 2024 · 0 comments · Fixed by #283
Closed

Add additional TFM do STJ can be eliminated #282

thompson-tomo opened this issue Apr 5, 2024 · 0 comments · Fixed by #283
Assignees
@thompson-tomo
Labels
enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Apr 5, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
System.Text.Json can become conditional and as such only added for the older frameworks.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a
thompson-tomo added a commit to thompson-tomo/cyclonedx-dotnet-library that referenced this issue Apr 6, 2024
@thompson-tomo
CycloneDX#282 Add net 5 and make STJ conditional
0942f60
@thompson-tomo thompson-tomo mentioned this issue Apr 6, 2024
Merged
thompson-tomo added a commit to thompson-tomo/cyclonedx-dotnet-library that referenced this issue Apr 6, 2024
@thompson-tomo
CycloneDX#282 Add net 5 and make STJ conditional
fddbae8 
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
@mtsfoni mtsfoni added the enhancement New feature or request label Apr 20, 2024
thompson-tomo added a commit to thompson-tomo/cyclonedx-dotnet-library that referenced this issue Apr 20, 2024
@thompson-tomo
CycloneDX#282 Add net 5 and make STJ conditional
cb7e40f 
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
thompson-tomo added a commit to thompson-tomo/cyclonedx-dotnet-library that referenced this issue May 20, 2024
@thompson-tomo
CycloneDX#282 Add net 5 and make STJ conditional
c168677 
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
mtsfoni pushed a commit that referenced this issue Sep 14, 2024
@thompson-tomo
feat: Add net 7 and make STJ conditional (#283)
48c27d0 
* #282 Add net 5 and make STJ conditional

Signed-off-by: James Thompson <thompson.tomo@outlook.com>

* Fix the multi targetting and extended it to another package

Signed-off-by: James Thompson <thompson.tomo@outlook.com>

* Switch to net 7 from net 5

Signed-off-by: James Thompson <thompson.tomo@outlook.com>

---------

Signed-off-by: James Thompson <thompson.tomo@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thompson-tomo thompson-tomo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#282 Add net 7 and make STJ conditional thompson-tomo/cyclonedx-dotnet-library
2 participants
@thompson-tomo @mtsfoni