Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

843 scope property is always being set to required #844

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mtsfoni
Copy link
Contributor

@mtsfoni mtsfoni commented Jan 28, 2024

No description provided.

Signed-off-by: MTsfoni <mibau89@gmail.com>
Signed-off-by: MTsfoni <mibau89@gmail.com>
Signed-off-by: MTsfoni <mibau89@gmail.com>
@mtsfoni mtsfoni requested a review from a team as a code owner January 28, 2024 18:06
@mtsfoni mtsfoni linked an issue Jan 28, 2024 that may be closed by this pull request
@thompson-tomo
Copy link

@mtsfoni will this fix also result in dependencies of the dev dependency also having their scope classified as excluded as I am needing that fixed as part of this.

@mtsfoni
Copy link
Contributor Author

mtsfoni commented Jan 29, 2024

You are right, it doesn't. That also seems a little trickier as the asset file, doesn't give the information directly.

Looks like I'd have to check the dependency graph and can mark one of those a dev dependency if every path towards the root include at least one dev dependency in-between.

Here D would be a dev dependency:

  B (dev) - D
 /
A

Here D cannot be a dev dependency:

  B (dev) - D
 /
A -  C  - D

Here, however, D would be a dev dependency again (all paths to A have a dev dependency on the way):

  B (dev) - D
 /
A -  C (dev) - D

@thompson-tomo do you happen to know a package in the gallery that will automatically be added as development dependency and has dependencies by itself? Most of those package have no dependencies by themselves.

@thompson-tomo
Copy link

I agree, it isn't as easy as would be hoped. So the main dev dependency package i am looking for a solution for would be Microsoft.VisualStudio.Web.CodeGeneration.Design & Microsoft.EntityFrameworkCore.Tools i am fairely sure atleast one of them is automatically added as a dev dependency,

Signed-off-by: MTsfoni <mibau89@gmail.com>
@mtsfoni
Copy link
Contributor Author

mtsfoni commented Jan 29, 2024

I will certainly solve this, as I consider it a bug. But I need to shift some things around in the process to make it work, so this is bigger task.

@mtsfoni
Copy link
Contributor Author

mtsfoni commented Feb 6, 2024

@mtsfoni will this fix also result in dependencies of the dev dependency also having their scope classified as excluded as I am needing that fixed as part of this.

Question: Do you need them specifically to be scope.excluded or is it also fine, if they just don't appear in the sbom at all? I learned that scope.excluded actually is meant for components that are necessary to use the software, but are not included in the scope of delivery.

@thompson-tomo
Copy link

Question: Do you need them specifically to be scope.excluded or is it also fine, if they just don't appear in the sbom at all? I learned that scope.excluded actually is meant for components that are necessary to use the software but are not included in the scope of delivery.

I don't specificially need the scope to be set to excluded and my comment was in response to the changes you had pushed. Happy for them to simply not appear in the SBOM especially if it makes things easier to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope property is always being set to required
2 participants