Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1.6): add BOM.Declarations #163

Merged
merged 1 commit into from
May 18, 2024
Merged

feat(1.6): add BOM.Declarations #163

merged 1 commit into from
May 18, 2024

Conversation

mcombuechen
Copy link
Contributor

This adds .Declarations to the BOM struct.

Closes #157.

@mcombuechen
Copy link
Contributor Author

mcombuechen commented May 15, 2024 •
edited
Loading

I'm keeping this as a draft for now since it depends on the JSF Signature type from #161, which can potentially be reused here.

Now rebased and updated, will mark as ready for review.

@mcombuechen mcombuechen force-pushed the 157-bom-declarations branch 2 times, most recently from 10fb226 to b6b89a3 Compare May 16, 2024 10:06
@mcombuechen mcombuechen marked this pull request as ready for review May 16, 2024 10:07
@mcombuechen mcombuechen requested a review from a team as a code owner May 16, 2024 10:07
@nscuro
Copy link
Member

nscuro commented May 17, 2024

@mcombuechen Thanks! Could you please resolve the merge conflict whenever you get the time?

@mcombuechen
feat(1.6): add BOM.Declarations
1f8fdcc 
Closes CycloneDX#157.

Signed-off-by: Maximilian Combüchen <max.combuchen@snyk.io>
@mcombuechen
Copy link
Contributor Author

@nscuro rebased and conflict free, should be ready for review now.

@nscuro nscuro merged commit 61ce290 into CycloneDX:spec/1.6 May 18, 2024
2 of 3 checks passed
@nscuro nscuro added enhancement New feature or request spec/1.6 labels May 18, 2024
@nscuro nscuro mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request spec/1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcombuechen @nscuro