Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storing file paths relative to module root #412

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

SweetVishnya
Copy link
Contributor

This PR introduces -paths options that enables storing of absolute file paths. This aims to reduce ambiguous file naming in generated SBOM.

@SweetVishnya SweetVishnya requested a review from a team as a code owner January 22, 2024 15:56
Signed-off-by: Alexey Vishnyakov <sweetvishnya@yandex-team.ru>
@SweetVishnya
Copy link
Contributor Author

@nscuro, can you take a look, please? And also run the CI tests?

internal/sbom/convert/file/file.go Outdated Show resolved Hide resolved
internal/sbom/convert/file/file.go Outdated Show resolved Hide resolved
Signed-off-by: Alexey Vishnyakov <sweetvishnya@yandex-team.ru>
Signed-off-by: Alexey Vishnyakov <sweetvishnya@yandex-team.ru>
@SweetVishnya
Copy link
Contributor Author

@nscuro, now I compute paths relatively to module root.

@SweetVishnya SweetVishnya changed the title Support storing absolute file paths Support storing file paths relative to module root Jan 24, 2024
@SweetVishnya
Copy link
Contributor Author

@nscuro, can we merge this PR?

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SweetVishnya! 🚀

@nscuro nscuro merged commit 6b624c3 into CycloneDX:main Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants