Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose the outputDirectory configuration parameter as a property #321

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

goldmann
Copy link
Contributor

Beware: this is a huge PR!

I found it a bit misleading that outputDirectory could not be configured by passing the property on command line. This fixes this behavior and makes it consistent with other parameters.

Signed-off-by: Marek Goldmann <mgoldman@redhat.com>
@hboutemy
Copy link
Contributor

for my understanding: in which scenario do you expect to set this value in CLI instead of pom.xml?

and don't you fear that such a generic outputDirectory name may conflict with other plugins?

@goldmann
Copy link
Contributor Author

for my understanding: in which scenario do you expect to set this value in CLI instead of pom.xml?

In a direct plugin execution where you want to have full control over where the BOM is generated without modifying the source code:

mvn org.cyclonedx:cyclonedx-maven-plugin:2.7.5:makeAggregateBom -DoutputFormat=json -DoutputName=bom -DoutputDirectory=output

and don't you fear that such a generic outputDirectory name may conflict with other plugins?

I imagine the same question should apply to other properties as well. I was following the pattern I could find within the source code, didn't want to derail from it. Of course I'm open for prefixing this (and other!) properties.

@hboutemy
Copy link
Contributor

thanks for the explanation
let's start as you proposed, we'll change the pattern later if there is any issue reported

merging and releasing, thanks for your help

@hboutemy hboutemy merged commit c93260c into CycloneDX:master Mar 30, 2023
@goldmann goldmann deleted the outputDirectory-property branch June 12, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants