Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2022-11-28] drop support of php<=7.4 #91

Closed
10 tasks done
jkowalleck opened this issue Jun 12, 2021 · 1 comment
Closed
10 tasks done

[2022-11-28] drop support of php<=7.4 #91

jkowalleck opened this issue Jun 12, 2021 · 1 comment
Labels
Milestone

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Jun 12, 2021


on 2022-11-28 the support for php7.4 will end.

lets take this for a change to switch the min-version of this plugin to 8 .
see https://www.php.net/manual/en/migration80.php
so to use the new language features, a breaking change will happen:

  • drop php7.4 from CI
  • drop php7.4 from composer manifest (php: ^8)
  • migrate to php8 via php-cs-fixer
  • review the proposals below

related: CycloneDX/cyclonedx-php-library#114


on 2021-12-06 the support for php7.3 ended.

lets take this for a change to switch the min-version of this plugin to 7.4 .
see https://www.php.net/manual/en/migration74.php
so to use the new language features, a breaking change will happen:

related: CycloneDX/cyclonedx-php-library#6


PROPOSAL: remove getters and setters, if a property can be made type safe and converted to public.

PRO

  • less methods to maintain

CON

  • no setters = cannot use chained setters ala $instance->setA(1)->setB(2);

code changes

from

class C {
  /** @var bool */
  private $prop = true;

  /** @return $this */
  public function setProp(bool $prop): self
  {
     $this->prop = $prop;
     return $this;
  }
}

to

class C {
  public bool $prop = true;
}

@jkowalleck jkowalleck added the maintenance maintenance tasks label Jun 12, 2021
@jkowalleck jkowalleck changed the title drop support of php7.3 [2021-12-06] drop support of php7.3 Jun 18, 2021
@jkowalleck jkowalleck added this to the v4 milestone Jul 16, 2021
@jkowalleck jkowalleck pinned this issue Dec 1, 2021
jkowalleck added a commit that referenced this issue Jan 4, 2022
related to #91

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Jan 4, 2022
related to #91

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title [2021-12-06] drop support of php7.3 [2022-11-28] drop support of php<=7.4 Jul 14, 2022
@jkowalleck
Copy link
Member Author

closed via #250

@jkowalleck jkowalleck unpinned this issue Dec 9, 2022
jkowalleck added a commit that referenced this issue Mar 11, 2023
* BREAKING changes
  * Removed support for PHP `<8.0` ([#91] via [#250])
  * Removed support for PHP `<8.1` (via [#250])
  * Removed support for Composer `<2.3` ([#153] via [#250])
  * CLI
    * Removed deprecated composer command `make-bom`, call `composer CycloneDX:make-sbom` instead ([#293] via [#309])
    * Changed option `output-file` to default to `-` now, which causes to print to STDOUT (via [#250])
    * Removed option `exclude-dev` in favour of new option `omit` (via [#250])
    * Removed option `exclude-plugins` in favour of new option `omit` (via [#250])
    * Removed option `no-version-normalization` ([#102] via [#250])
  * SBOM results
    * Components' version is no longer artificially normalized ([#102] via [#250])
  * Dependencies
    * Requires `cyclonedx/cyclonedx-library:^2.0`, was `:^1.4.2` ([#128] via [#250])
* Changed
  * Evidence analysis prefers actually installed packages over lock file ([#122] via [#250])
  * Root component's versions is unset, if version detection fails ([#154] via [#250])
  * Composer packages of type "composer-installer" are treated as composer plugins (via [#250])
* Added
  * Evidence collection knows actually installed packages ([#122] via [#250])
  * SBOM results
    * Support for CycloneDX Spec v1.4 (via [#250])
    * might have `serialnumber` populated ([#279] via [#250])
    * might have `metadata.timestamp` populated ([#112] via [#250])
    * might have `metadata.tools[].tool.externalReferences` populated ([#171] via [#250])
    * might have `components[].component.author` populated ([#261] via [#250])
    * might have `components[].component.properties` populated according to [`cdx:composer` Namespace Taxonomy](https://github.com/CycloneDX/cyclonedx-property-taxonomy/blob/main/cdx/composer.md) (via [#250])
  * CLI
    * New option `omit` (via [#250])
    * New switch `validate` to override `no-validate` (via [#250])
    * New switches `output-reproducible` and `no-output-reproducible` (via [#250])
* Misc
  * Added demo and reproducible continuous integration test "devReq" that is dedicated to composer's `require-dev` feature (via [#250])
  * Reworked demo setups to be more global-install like (via [#250])

[#91]:  #91
[#102]: #102
[#112]: #112
[#122]: #122
[#128]: #128
[#153]: #153
[#154]: #154
[#171]: #171
[#250]: #250
[#261]: #261
[#279]: #279
[#293]: #293
[#309]: #309
[#313]: #313

---------

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck mentioned this issue Mar 11, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant