Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] bom.properties missing from JSON schema in version 1.4 #130

Closed
madpah opened this issue Feb 2, 2022 · 3 comments · Fixed by #170
Closed

[BUG] bom.properties missing from JSON schema in version 1.4 #130

madpah opened this issue Feb 2, 2022 · 3 comments · Fixed by #170
Assignees
@stevespringett
Labels
defect request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration RFC vote accepted
Milestone
1.5

Comments

@madpah
Copy link

madpah commented Feb 2, 2022

When reviewing and comparing:

...the JSON schema is missing bom.properties compared to the XML version.

FYI @stevespringett
@stevespringett stevespringett added this to the 1.5 milestone Feb 2, 2022
@madpah madpah mentioned this issue Feb 2, 2022
Closed
@stevespringett stevespringett self-assigned this Oct 3, 2022
stevespringett added a commit that referenced this issue Dec 13, 2022
@stevespringett
Resolves #130 - Added missing BOM properties to JSON and proto schemas
280fbaa 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett stevespringett mentioned this issue Jan 23, 2023
Merged
@stevespringett stevespringett linked a pull request Jan 23, 2023 that will close this issue
Resolves #130 - missing BOM properties in JSON and protobuf schemas #170
Merged
@stevespringett stevespringett added request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration labels Jan 23, 2023
@DarthHater
Copy link
Member

@mr-zepol and I checked, it looks like we don't need to fix this with cyclonedx-core-java, I think we were "smart" and added it way back when, but it looks like maybe it didn't get added everywhere?

@jkowalleck
Copy link
Member

@DarthHater I hope you were also smart when it came to output generation. Since CDX1.4 JSON schema is strict, it would not allow a bom.properties element at all.
If you rendered such an element anway, then the resulting document would be considdered invalid as a whole, due to schema definitions. Tools that validate for the schema to check if a document suited the needs would claim that such a document would be unusable.

@jkowalleck jkowalleck mentioned this issue Feb 17, 2023
Closed
7 tasks
stevespringett added a commit that referenced this issue Feb 20, 2023
@stevespringett
Merge pull request #170 from CycloneDX/v1.5-dev-#130-bom-properties
b252f0d 
Resolves #130 - missing BOM properties in JSON and protobuf schemas
@stevespringett
Copy link
Member

Scheduled for inclusion in v1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevespringett stevespringett

Labels
defect request for comment RFC notice sent A public RFC notice was distributed to the CycloneDX mailing list for consideration RFC vote accepted
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

Resolves #130 - missing BOM properties in JSON and protobuf schemas CycloneDX/specification
4 participants
@jkowalleck @stevespringett @DarthHater @madpah