rework dependency type to provides
#366
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
1.6-dev-cbom-provides
branch
from
4beff88
to
d8ae85e
Compare
|
@bhess could I ask you for a review? |
| // Defines and characterizes the type of dependency | ||
| optional DependencyType type = 3; | ||
| // The bom-ref identifiers of the components or services that define a given specification or standard, which are provided or implemented by this dependency object. | ||
| repeated string provides = 3; |
There was a problem hiding this comment.
provides is a verb. Can we use a bit generic like capabilities to indicate a state and not an action?
There was a problem hiding this comment.
providesis a verb. Can we use a bit generic likecapabilitiesto indicate a state and not an action?
for protobuff, I'd agree. a noun would go with the current naming conventions.
for JSON/XML, ... not certain.
PS: i am open to suggestions for alternative names.
There was a problem hiding this comment.
Sounds like your suggestion for capabilities @prabhu would be a good fit for what we're doing with CDX 1.7 - specifically architecture and blueprints.
| // Defines and characterizes the type of dependency | ||
| optional DependencyType type = 3; | ||
| // The bom-ref identifiers of the components or services that define a given specification or standard, which are provided or implemented by this dependency object. | ||
| repeated string provides = 3; |
There was a problem hiding this comment.
Sounds like your suggestion for capabilities @prabhu would be a good fit for what we're doing with CDX 1.7 - specifically architecture and blueprints.
changes as discussed here: #347 (comment)