-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework dependency type to provides
#366
rework dependency type to provides
#366
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
4beff88
to
d8ae85e
Compare
@bhess could I ask you for a review? |
// Defines and characterizes the type of dependency | ||
optional DependencyType type = 3; | ||
// The bom-ref identifiers of the components or services that define a given specification or standard, which are provided or implemented by this dependency object. | ||
repeated string provides = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provides
is a verb. Can we use a bit generic like capabilities
to indicate a state and not an action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provides
is a verb. Can we use a bit generic likecapabilities
to indicate a state and not an action?
for protobuff, I'd agree. a noun would go with the current naming conventions.
for JSON/XML, ... not certain.
PS: i am open to suggestions for alternative names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like your suggestion for capabilities
@prabhu would be a good fit for what we're doing with CDX 1.7 - specifically architecture and blueprints.
// Defines and characterizes the type of dependency | ||
optional DependencyType type = 3; | ||
// The bom-ref identifiers of the components or services that define a given specification or standard, which are provided or implemented by this dependency object. | ||
repeated string provides = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like your suggestion for capabilities
@prabhu would be a good fit for what we're doing with CDX 1.7 - specifically architecture and blueprints.
changes as discussed here: #347 (comment)