tests: Update to cyclonedx-core-java-9.0.2 for test runners #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com> Fix typo O instead of zero 0 Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@owasp.org>
https://github.com/CycloneDX/cyclonedx-core-java/releases/tag/cyclonedx-core-java-9.0.2 Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
Update xmlcatalog.xml with a comment about DTD
… schema files Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
…. Starting prototyping the XML Catalog tests Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
…s the content of the XML catalog is ready. Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
…se it was override by adding a line to the schema folder Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
jkowalleck
requested changes
Jun 12, 2024
tools/src/test/java/org/cyclonedx/schema/BaseSchemaVerificationTest.java
Outdated
Show resolved
Hide resolved
tools/src/test/java/org/cyclonedx/schema/XmlCatalogVerificationTest.java
Outdated
Show resolved
Hide resolved
tools/src/test/java/org/cyclonedx/schema/XmlSchemaVerificationTest.java
Outdated
Show resolved
Hide resolved
tools/src/test/java/org/cyclonedx/schema/JsonSchemaVerificationTest.java
Outdated
Show resolved
Hide resolved
…remove here everything related to the XML catalog. Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
Signed-off-by: Nicolas-Peiffer <102670102+Nicolas-Peiffer@users.noreply.github.com>
jkowalleck
approved these changes
Jun 13, 2024
jkowalleck
changed the title
|
Thank you @jkowalleck for your help and for your responsiveness 😃 . Thanks to your detailed comments, I think the content of the PR was improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #477
Please merge this PR after merging #479.PR is atomic.
Tests are testing the 1.6 JSON and XML files.this will come in an extra PR