Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding all chapters for lesson 2 #4

Merged
merged 8 commits into from
Jul 12, 2023
Merged

adding all chapters for lesson 2 #4

merged 8 commits into from
Jul 12, 2023

Conversation

PatrickAlphaC
Copy link
Member

No description provided.

@cromewar cromewar changed the title adding errors and warnings adding all chapters for lesson 2 Jul 11, 2023
@cromewar cromewar marked this pull request as ready for review July 11, 2023 23:29
@PatrickAlphaC
Copy link
Member Author

  • let's number the parts in a lesson, it's a little tricky to read

PatrickAlphaC
PatrickAlphaC commented Jul 12, 2023
View reviewed changes
Copy link
Member Author

@PatrickAlphaC PatrickAlphaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions on specifically calldata instead of call data, but other than that, these look great!

The images too are outstanding.

src/routes/solidity/remix/1-simple-storage/6-errors-and-warnings/+page.md

To recap:

- If it's <span style="color:red">*red*</span>, it's broken.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great touch

src/routes/solidity/remix/1-simple-storage/10-evm-recap/+page.md Outdated Show resolved Hide resolved
src/routes/solidity/remix/1-simple-storage/7-memory-storage-calldata/+page.md Outdated Show resolved Hide resolved
src/routes/solidity/remix/1-simple-storage/7-memory-storage-calldata/+page.md Outdated Show resolved Hide resolved
src/routes/solidity/remix/1-simple-storage/7-memory-storage-calldata/+page.md Show resolved Hide resolved
src/routes/solidity/remix/1-simple-storage/7-memory-storage-calldata/+page.md Outdated Show resolved Hide resolved
src/routes/solidity/remix/1-simple-storage/7-memory-storage-calldata/+page.md Outdated Show resolved Hide resolved
src/routes/solidity/remix/1-simple-storage/7-memory-storage-calldata/+page.md Outdated Show resolved Hide resolved
@PatrickAlphaC PatrickAlphaC merged commit e14a754 into main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickAlphaC @cromewar