Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detector: Boolean equality #633

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Detector: Boolean equality #633

merged 6 commits into from
Aug 5, 2024

Conversation

TilakMaddy
Copy link
Collaborator

No description provided.

@TilakMaddy TilakMaddy marked this pull request as ready for review July 29, 2024 12:56
alexroan
alexroan requested changes Aug 2, 2024
View reviewed changes
aderyn_core/src/detect/detector.rs Outdated Show resolved Hide resolved
aderyn_core/src/detect/high/boolean_equality.rs Outdated Show resolved Hide resolved
alexroan
alexroan requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@alexroan alexroan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TilakMaddy I think the requested changes were applied to the wrong detector.

aderyn_core/src/detect/high/boolean_equality.rs Outdated Show resolved Hide resolved
aderyn_core/src/detect/low/misused_boolean.rs Outdated Show resolved Hide resolved
@TilakMaddy
Copy link
Collaborator Author

✅

@alexroan alexroan merged commit 155a9d6 into dev Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexroan alexroan alexroan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TilakMaddy @alexroan