Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize internal shared code dependency #707

Merged
merged 9 commits into from
Oct 30, 2023
Merged

Reorganize internal shared code dependency #707

merged 9 commits into from
Oct 30, 2023

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented Oct 30, 2023 •
edited
Loading

  • Move MessagePackMagicOnionSerializerProvider to MagicOnion.Serialization.MessagePack assembly
    • Change namespace MagicOnion.Serialization to MagicOnion.Serialization.MessagePack
  • Move DynamicArgumentTupleFormatter to MagicOnion.Serialization.MessagePack assembly
    • Change namespace MagicOnion to MagicOnion.Serialization.MessagePack
  • Move UnsafeDirectBlitResolver to MagicOnion.Serialization.MessagePack assembly
  • Move DynamicArgumentTuples to MagicOnion.Abstractions assembly
  • Move IMagicOnionSerializerProvider and IMagicOnionSerializer to MagicOnion.Abstractions assembly
  • Internalize some types in MagicOnion.Shared

@mayuki mayuki merged commit 4c72b41 into main Oct 30, 2023
3 checks passed
@mayuki mayuki deleted the feature/ReorganizeDependency branch October 30, 2023 07:32
@mayuki mayuki mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mayuki