Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GenerateSerializerType into MagicOnionClientGenerationAttribute #748

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mayuki
Copy link
Member

@mayuki mayuki commented Mar 21, 2024

Fixes #738

GenerateSerializerType remains after compiling, which causes conflicts with InternalsVisibleTo.
Accordingly, GenerateSerializerType has been moved under MagicOnionClientGenerationAttribute, which is a breaking change.

Before

[MagicOnionClientGeneration(typeof(IGreeterService), Serializer = GenerateSerializerType.MemoryPack)]
partial class MagicOnionInitializer {}

After

[MagicOnionClientGeneration(typeof(IGreeterService), Serializer = MagicOnionClientGenerationAttribute.GenerateSerializerType.MemoryPack)]
partial class MagicOnionInitializer {}

@mayuki mayuki merged commit 8d367a0 into main Mar 21, 2024
3 checks passed
@mayuki mayuki deleted the feature/FixGenerateSerializerTypeVisibility branch March 21, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalsVisibleTo lead to warnings on dependent project
1 participant