Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add (Write/Read)AsPropertyName methods #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roflmuffin
Copy link

Currently, Ulids cannot be used as dictionary keys when serializing to JSON. i.e. IDictionary<Ulid, int>() will not serialize correctly with the error:

System.NotSupportedException
The type 'System.Ulid' is not a supported dictionary key using converter of type 'Cysharp.Serialization.Json.UlidJsonConverter'. 

This PR adds support for WriteAsPropertyName and ReadAsPropertyName to allow for this use case.

Copy link
Contributor

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant