Skip to content

Fix issue# 8403: ^^ and ^^= missing from lexical documentation. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2012

Conversation

jmdavis
Copy link
Member

@jmdavis jmdavis commented Jul 21, 2012

No description provided.

@jmdavis
Copy link
Member Author

jmdavis commented Jul 21, 2012

I found another bug in lex.html (bug #8406), so I just added the fix for it to this pull request, since it's the same file, and neither change is large.

@@ -236,6 +238,8 @@ $(GNAME Token):
$(B %=)
$(B ^)
$(B ^=)
$(B ^^)
$(B ^^=)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokens ^^ and ^^= are valid only in D2, so you should enclose them with $(V2 ...) macro.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even notice that there was such a macro (though I should have, since it's used a few lines below that). Does that mean that the online documentation can also be generated for D1 using the same files? I wouldn't have thought that would have worked at all, given the large differences between them. Well, at least we'll be able to ditch macros like that come the first of next year.

In any case, I've now added the macros.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether current D1 documentation (digitalmars.d/d/1.0) is really generated from this repository. But Walter sometimes mentioned about it for past pull requests. So, considering about it is not bad.

Well, at least we'll be able to ditch macros like that come the first of next year.

Yes. I'm looking forward to it.

@andralex
Copy link
Member

Thanks!

andralex added a commit that referenced this pull request Jul 23, 2012
Fix issue# 8403: ^^ and ^^= missing from lexical documentation.
@andralex andralex merged commit 44c4e56 into dlang:master Jul 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants