Give suggestions on both error and success after fetching LATEST #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,9 +64,9 @@ LATEST:=$(shell cd ${DMD_DIR} && \ | |||
| git tag | grep '^v[0-9][0-9.]*$$' | sed 's/^v//' | sort -nr | head -n 1) | |||
| endif | |||
| ifeq (,${LATEST}) | |||
| $(error Could not fetch latest version) | |||
| $(error Could not fetch latest version, place LATEST=2.xyz in the command line) | |||
There was a problem hiding this comment.
It's either one or the other. Which is more common?
There was a problem hiding this comment.
Um? All recent releases are in the form 2.NNN.N. Not sure what you mean.
The pull request title is not visible when browsing commits. |
andralex
force-pushed
the
better-messages-for-latest
branch
from
48d763b to
dbc0fe7
Compare
|
@CyberShadow fixed |
andralex
force-pushed
the
better-messages-for-latest
branch
from
dbc0fe7 to
82d550b
Compare
CyberShadow
added a commit
that referenced
this pull request
Jun 8, 2015
Give suggestions on both error and success after fetching LATEST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.