Skip to content

Various front-page example fixes #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2015

Conversation

CyberShadow
Copy link
Member

@CyberShadow
Copy link
Member Author

Instead of removing the two examples requiring network access, they could be added to the exclusion list, which would hide the edit/run buttons. Of course that would mean that the first example visitors see might not be runnable online. Thoughts?

@andralex
Copy link
Member

I'd say we go for simplicity. Just put code that works in there, and don't put code that doesn't.

@MartinNowak
Copy link
Member

Instead of removing the two examples requiring network access

Regarding http://forum.dlang.org/post/wuchoevfdcnwvpuldiqd@forum.dlang.org I though network access was now allowed. Is that correct @nazriel?
I think it's a major downer to not provide any network examples, and instead show some pointless line counting examples. Maybe when the backend is renewed, you can use LXC/docker to limit the network traffic to something reasonable and at least allow http(s).

MartinNowak added a commit that referenced this pull request Oct 10, 2015
@MartinNowak MartinNowak merged commit c459d6c into dlang:master Oct 10, 2015
@MartinNowak
Copy link
Member

@CyberShadow
Copy link
Member Author

Regarding http://forum.dlang.org/post/wuchoevfdcnwvpuldiqd@forum.dlang.org I though network access was now allowed. Is that correct @nazriel?

If network programs don't work then I guess it's not live yet.

However, my opinion is that we should NOT allow networked programs to run. It creates a very appealing target for amplifying DoS attacks, using the site as a proxy, etc. I think similar sandboxes also block network access for similar reasons.

I think it's a major downer to not provide any network examples, and instead show some pointless line counting examples. Maybe when the backend is renewed, you can use LXC/docker to limit the network traffic to something reasonable and at least allow http(s).

I don't know. I'm not sure the websites we do allow network access to will be happy about it. If we get an influx of users, we'll use up their website's resources without them getting anything back (like ad views).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants