-
-
Notifications
You must be signed in to change notification settings - Fork 380
Left Align Text #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left Align Text #1152
Conversation
@andralex is passionate about hyphenated, double justified text (there is quite a lot of discussion on the forums about this). Chrome is more or less the only major browser left that doesn't support We used, for a long time, a javascript hyphens emulating script that was terrible and we finally ditched it. If you want to try to convince Andrei of doing this I suspect it'll have to be Chrome only and have to be reverted once Chromium implements |
I'm okay with left aligned on Chrome only. Thanks. |
IIRC Andrei said that an article written by a typography / web design expert could change his mind, but when we discussed the issue last time there was no such piece that would conclusively weigh it either way. Perhaps it might be worth asking on StackExchange / Quora. I personally also agree that hyphenation doesn't belong on the web, but as it is it's opinion versus Andrei's background in typography. |
dc8fc82
to
770242e
Compare
@eco @andralex @CyberShadow changed CSS to only target chrome. This was tested on Chrome and Safari on OS X, so if you can tell me if it works on your system that would be great. |
@CyberShadow Did you accidentally comment on the wrong PR? |
Oops, yes :) Deleted & reposted. |
I see this removes |
@andralex If you look in the diff section that's not shown by github by default, you'll see that for some reason, the |
/* This is a CSS hack to only target Blink based browsers | ||
Targets Chrome 28 and later and Opera 14 and later | ||
*/ | ||
@media all and (-webkit-min-device-pixel-ratio:0) and (min-resolution: .001dpcm) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch at this hack. There has to be a better way, even if it involves JS. Ideally a bit of JS will detect if hyphenation is actually supported by the browser or not, I think hyphenate.js has such a chechk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to avoid JS if at all possible because I don't like putting style inside of anything but the CSS, as it has a high probability of being forgotten and left in there for a while. And I figured that it wasn't so bad as this will probably be removed soon when Chrome supports hyphens.
If you still want me to change this to a JS solution even with the above problems, please let me know.
Please rebase! (I guess due to detabbing in your other PR?) |
770242e
to
d4340a0
Compare
@CyberShadow fixed |
Thanks. |
I know that discussing styling decisions on the internet is a road full of personal opinion and flame wars, so I want to keep this discussion purely practical by stating this: justified text is harder to read on the web than left aligned text.
A good summary of the problems and the evidence behind them can be found here: https://kaiweber.wordpress.com/2010/05/31/ragged-right-or-justified-alignment/. TL;DR is that it makes little difference for people who can read well, but for people with dyslexia or other reading disabilities, justified text is much harder for them to comprehend.
Also, the reason that most books are justified is they are done by hand or reviewed and edited by someone after a automatic process is finished. Automatic justifying software is just not up to the task in most cases, creating lots of weird hyphenations, off line breaks, and rivers in text, e.g. https://en.wikipedia.org/wiki/River_(typography)#/media/File:Typographic_river.svg
For some less scientific evidence, if you look on the web at sites that are purely designed to have a good reading experience for long form content, Medium, Feedly, Pocket, Instapaper, Readability, and Safari's built-in Reader View, they all use left aligned text.