Skip to content

Update cpp_interface.dd for recent developments #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2016

Conversation

JakobOvrum
Copy link
Member

  • Removes old assumptions
  • Specifies the new type and template stuff, with examples
  • Updated memory allocation section
  • Updated data type table

Depends on: issue 15372. The template example doesn't link.

The first commit contains only the tabs to spaces changes, so it's probably easier to review using the diff for the second commit.

)

$(TROW
$(ARGS $(B core.stdc.stddef.wchar_t)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to be causing some error in the LaTex generation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because of the underscore I think. Use $(UNDERSCORE) instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or use $(D ...), as is more appropriate here because you're referring to an identifier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. I changed it to use $(D ...) and the test passes now.

@JakobOvrum
Copy link
Member Author

I filed the linking issue: https://issues.dlang.org/show_bug.cgi?id=15372

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
10987 Add documentation for 'extern (C++)' classes

@JackStouffer
Copy link
Member

So this is blocked by 15372? If so it would be useful if someone added the "Blocked" tag to this.

@JakobOvrum
Copy link
Member Author

Well, I could just remove function templates from the article. I just can't claim it works when it doesn't.

@JackStouffer
Copy link
Member

I'd say add a note about bug 15372 and then merge this, as this shows how C++ inter-op should work baring bugs and that's how we document everything else.

@JackStouffer
Copy link
Member

@JakobOvrum rebase please

@JakobOvrum
Copy link
Member Author

Is the BUGZILLA macro broken for latex output?

@CyberShadow
Copy link
Member

Is the BUGZILLA macro broken for latex output?

Seems so.

@JakobOvrum JakobOvrum force-pushed the update_cpp_interface branch from d871767 to 4a805d4 Compare January 20, 2016 09:33
@JakobOvrum JakobOvrum force-pushed the update_cpp_interface branch from 4a805d4 to 04427d2 Compare January 20, 2016 09:39
@deadalnix
Copy link

Is there a way to see the page somewhere ?

@JakobOvrum
Copy link
Member Author

This PR now depends on #1194 for MREF.

Is there a way to see the page somewhere ?

The build is failing because of a missing LaTeX macro (added in #1194), so I guess not.

@adamdruppe
Copy link
Contributor

I just merged 1194, if the test re-runs here, ping me and I'll merge this too.

@tsbockman
Copy link
Contributor

@adamdruppe The test has passed now.

schuetzm added a commit that referenced this pull request Mar 12, 2016
Update cpp_interface.dd for recent developments
@schuetzm schuetzm merged commit 5a67123 into dlang:master Mar 12, 2016
@tsbockman
Copy link
Contributor

Thanks for this. When will this actually go live on the website?

@CyberShadow
Copy link
Member

The next time I, Martin or Andrei syncs it.

Would you like me to sync it now?

@tsbockman
Copy link
Contributor

@CyberShadow

Would you like me to sync it now?

That would be nice. Thanks.

People ask about C++ support from time to time on the forums, and I'd like to finally be able to just say, "go read the spec".

@CyberShadow
Copy link
Member

@tsbockman
Copy link
Contributor

Thanks. Any idea why "COM interface" at the top of the page is a dead link?

@CyberShadow
Copy link
Member

It seems to be using the wrong macro. But http://dlang.org/COM.html is just a redirect to a wiki page with one line in it. The link should probably just be removed.

@tsbockman
Copy link
Contributor

@CyberShadow

The link should probably just be removed.

I made a PR: #1249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants