Skip to content

Revert "Ivan Smirnov's redesign" #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

andralex
Copy link
Member

Reverts #1187. Guess we're not ready yet, at least on account of http://downloads.dlang.org not working.

@aG0aep6G
Copy link
Contributor

LGTM ;)

@MartinNowak
Copy link
Member

Oh, that's a good opportunity to redo that subdomain :).
I already tried to integrate it w/ dlang.org at some point and we really need to do this, even though braddr didn't like the idea ¹.
But now we want to integrate nightlies as well ² so we should come up w/ something better. I'd be in favor of completely integrating downloads.dlang.org with dlang.org (the repo and maybe even the subdomain). The tricky part of course is to keep that in sync w/ an ever changing list of files.
Any ideas or preferences?

CyberShadow added a commit that referenced this pull request Jan 11, 2016
…-Smirnov's-redesign

Revert "Ivan Smirnov's redesign"
@CyberShadow CyberShadow merged commit b6fddab into master Jan 11, 2016
@CyberShadow
Copy link
Member

Thanks all. I agree that this is great work that we must act upon, but let's pace ourselves.

Oh, that's a good opportunity to redo that subdomain :).

The way I did this for forum.dlang.org is to include a copy of dlang.org as a Git submodule. This way, it is still based on dlang.org CSS/DDoc, can be easily updated to the latest design, but still locked to a specific version to avoid dlang.org changes breaking the forum.

@andralex
Copy link
Member Author

@CyberShadow please don't forget to also sync the site

@dnadlinger dnadlinger deleted the revert-1187-Ivan-Smirnov's-redesign branch January 11, 2016 04:41
@CyberShadow
Copy link
Member

@CyberShadow please don't forget to also sync the site

OK, done (was hoping someone else could do it as I'm not home yet)

aG0aep6G added a commit to aG0aep6G/dlang.org that referenced this pull request Jan 11, 2016
…ert-1187-Ivan-Smirnov's-redesign"

This reverts commit b6fddab, reversing
changes made to 910c4f6.
aG0aep6G added a commit to aG0aep6G/dlang.org that referenced this pull request Jan 14, 2016
…ert-1187-Ivan-Smirnov's-redesign"

This reverts commit b6fddab, reversing
changes made to 910c4f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants