Ivan smirnov's redesign (2nd try) #1190

aG0aep6G · 2016-01-11T12:23:48Z

Do not merge. This breaks downloads.dlang.org.

Forum thread: http://forum.dlang.org/post/n6pdes$1upn$1@digitalmars.com

This being a revert of a revert, the little commit information that was there is gone. It can be seen over at #1187.

Reitering that someone should probably recreate the Twitter widget from a different account. #1187 (comment)

andralex · 2016-01-11T15:00:33Z

@CyberShadow are you on this? Let me know if you need help. Thx!

JakobOvrum · 2016-01-11T23:03:07Z

articles.dd

+                    reference, and what the article calls a $(I dynamic array)
+                    is not named specifically by the language reference. Still,
+                    the article is a great help in getting a good understanding
+                    of D's array semantics.)


Unfortunately the language spec uses different terminology from this article ;)

MartinNowak · 2016-01-12T19:23:24Z

Thanks, any ideas for downloads.dlang.org? We could operate w/ a stripped down version until we redesign it as well.

aG0aep6G · 2016-01-12T20:10:50Z

I've made a companion PR for forum.dlang.org: CyberShadow/DFeed#51. That needs some changes to dlang.org's forum-template.dd. I've added them here.

aG0aep6G · 2016-01-12T20:23:42Z

Thanks, any ideas for downloads.dlang.org? We could operate w/ a stripped down version until we redesign it as well.

Where is the git repository of downloads.dlang.org? Updating forum.dlang.org went pretty smoothly, so maybe I can just do downloads.dlang.org over the next couple days, and then we can make the switch for everyone at the same time.

Alternatively, we can freeze downloads.dlang.org in the old design by using copies of the dlang.org files (via git submodule) instead of using the online files. This may be a good idea anyway so that we don't accidentally break things again.

CyberShadow · 2016-01-12T23:06:10Z

As an option I guess we could leave style.css etc. alone, and use new filenames for files used in the new design. But of course we should update it instead if possible.

So I don't know these things either:

Where is the source code for the downloads.dlang.org page templates?
How can we build and preview it?
Who can update it and push it to the live site?

MartinNowak · 2016-01-12T23:39:35Z

Unfortunately it's not possible to generate the pages w/o an S3 account.
https://github.com/MartinNowak/downloads.dlang.org
Please don't put too much effort into this b/c we have to come up w/ something else in order to integrate the nightlies. I'd say updating the template so it's operable should be good enough for now.

CyberShadow · 2016-01-12T23:42:31Z

Unfortunately it's not possible to generate the pages w/o an S3 account.

Doesn't look so bad, maybe a second main inside version(test) which supplies dummy data to buildIndex.

MartinNowak · 2016-01-13T00:08:36Z

Doesn't look so bad, maybe a second main inside version(test) which supplies dummy data to buildIndex.

I can just do that, so you guys can work on the template.

CyberShadow · 2016-01-13T00:41:08Z

download.dd

-<!-- Github ribbon -->
-<a href="http://github.com/D-Programming-Language"><img id="github-ribbon"
-src="images/github-ribbon.png" alt="Fork D on GitHub"></a>
-


Since the GitHub ribbon is removed, I think there should be a link to the source code somewhere (e.g. near the release archive / GPG keys links).

I don't think we need a link to GitHub on the downloads page, but here you go. Added a commit: aG0aep6G@2d1d95d

CyberShadow · 2016-01-13T00:49:35Z

This seems to break building the CHM. I'll look into it.

MartinNowak · 2016-01-13T01:46:42Z

I can just do that, so you guys can work on the template.

There you go MartinNowak/downloads.dlang.org@eed9a51...MartinNowak:9bd901c95681ce827da46fcd5aacc708266f953b, now generates html from a json file.

git clone git://github.com/MartinNowak/downloads.dlang.org.git
cd downloads.dlang.org
make -C src
cp test_index.json index.json
./src/build-gen-index generate

Not sure if it works on Windows though (it's using / to construct paths everywhere).

CyberShadow · 2016-01-13T03:41:05Z

How about a changelog SUBNAV?

CyberShadow · 2016-01-13T04:54:59Z

This seems to break building the CHM. I'll look into it.

aG0aep6G#2

CyberShadow · 2016-01-13T05:54:20Z

What's with the link to the non-existing /menu.html ?

CyberShadow · 2016-01-13T06:33:47Z

Main page screenshot with restyled forum widgets:

MartinNowak · 2016-01-13T14:33:08Z

Nice

CyberShadow · 2016-01-13T14:44:13Z

The D logo is broken in IE 11 (only top right corner is shown), maybe the SVG needs to be "resized".

aG0aep6G · 2016-01-13T19:59:34Z

What's with the link to the non-existing /menu.html ?

/menu.html should be there. It's a no-JS fallback page.

menu.dd is here: https://github.com/D-Programming-Language/dlang.org/pull/1190/files#diff-39b0dfe44d7b515b991a96b903b95f9b

And here it is in posix.mak: https://github.com/D-Programming-Language/dlang.org/pull/1190/files#diff-228b518f4545d060f900578830ade5daR172

aG0aep6G · 2016-01-13T20:03:32Z

Incorporated @CyberShadow's CHM fixes. Can't say that I have reviewed them. I don't know a thing about the CHM stuff.

aG0aep6G · 2016-01-13T20:38:40Z

How about a changelog SUBNAV?

Added: aG0aep6G@43ca3df

CyberShadow · 2016-01-13T23:27:18Z

/menu.html should be there. It's a no-JS fallback page.

Hm, OK. Not sure what I did to get a 404, but I can see it's all there.

Added: aG0aep6G/dlang.org@43ca3df

Nice!

CyberShadow · 2016-01-13T23:32:32Z

Incorporated @CyberShadow's CHM fixes. Can't say that I have reviewed them. I don't know a thing about the CHM stuff.

Most of it has been shuffling the navigation macros to allow emitting a complete navigation tree in a JSON-ish format that chmgen can parse.

CyberShadow · 2016-01-14T02:14:33Z

@aG0aep6G Will you be looking into updating the downloads.dlang.org template? That currently has the highest priority.

…ert-1187-Ivan-Smirnov's-redesign" This reverts commit b6fddab, reversing changes made to 910c4f6.

aG0aep6G · 2016-01-14T14:47:06Z

Pull request for downloads.dlang.org - quick and dirty, not making it more robust against future breakage: https://github.com/MartinNowak/downloads.dlang.org/pull/1

The Visual D pages need to put a non-ROOT_DIR path there.

aG0aep6G · 2016-01-14T18:56:34Z

And here's a PR for the Visual D pages: dlang/visuald#57

aG0aep6G · 2016-01-14T20:50:40Z

The D logo is broken in IE 11 (only top right corner is shown), maybe the SVG needs to be "resized".

Added a commit to fix that, and one to fix the search dropdown style.

andralex · 2016-01-15T05:02:40Z

Thanks all for the hard work! @CyberShadow @MartinNowak are we on track to push the bits to dlang.org on Friday (essentially 12 hours from now)?

CyberShadow · 2016-01-15T05:09:43Z

Blockers:

downloads.dlang.org (waiting on Martin)

Non-blocking issues:

forum.dlang.org tweaks (see discussion on Ivan Smirnov's redesign CyberShadow/DFeed#51 and forum thread)

Possible issues (needs more discussion):

Change the web font (or not) to a standard one
Make the gray color used in code comments and other areas darker

Looks a bit nicer with the sidebar. Also helps forum.dlang.org with height calculations.

Also fix a subtle alignment issue that would show when expanding/collapsing an item in the phobos subnav.

aG0aep6G · 2016-01-15T20:37:42Z

Added two commits:

move #copyright into #content - Looks a bit nicer with the sidebar. Also helps forum.dlang.org with height calculations.
give the subnav a left border too - People complained that it looked weird before: http://forum.dlang.org/post/qcubliszoceqjchcvqrl@forum.dlang.org

MartinNowak · 2016-01-16T18:05:51Z

downloads.dlang.org (waiting on Martin)

Merged https://github.com/MartinNowak/downloads.dlang.org/pull/1, anything else?

CyberShadow · 2016-01-17T01:57:59Z

Merged MartinNowak/downloads.dlang.org#1, anything else?

I guess no, we just need to deploy this PR and downloads.dlang.org in tandem.

andralex · 2016-01-17T03:10:28Z

@CyberShadow wanna do the honors?

CyberShadow · 2016-01-17T03:11:04Z

Well, I think @MartinNowak should do that since I can't update downloads.dlang.org.

andralex · 2016-01-17T03:11:32Z

@MartinNowak you got the red button

Safari seems to have problems with word-spacing.

aG0aep6G · 2016-01-17T15:55:35Z

Added a last minute fix as per CyberShadow/DFeed#52 (comment)

MartinNowak · 2016-01-17T16:15:22Z

Will deploy this in an hour.

Ivan smirnov's redesign (2nd try)

MartinNowak · 2016-01-17T18:11:21Z

Will deploy this in an hour.

Done, don't forget to press F5.

JakobOvrum reviewed Jan 11, 2016
View reviewed changes

aG0aep6G mentioned this pull request Jan 12, 2016

Ivan Smirnov's redesign CyberShadow/DFeed#51

Merged

CyberShadow reviewed Jan 13, 2016
View reviewed changes

aG0aep6G force-pushed the Ivan-Smirnov's-redesign branch from 427c257 to e013cf7 Compare January 13, 2016 23:29

Revert "Merge pull request dlang#1189 from D-Programming-Language/rev…

d339bfe

…ert-1187-Ivan-Smirnov's-redesign" This reverts commit b6fddab, reversing changes made to 910c4f6.

fix long options in the search dropdown

040069d

aG0aep6G force-pushed the Ivan-Smirnov's-redesign branch from e013cf7 to 040069d Compare January 14, 2016 13:23

SUBNAV_HEAD macro: move $(ROOT_DIR) to instantiation site

44d1c79

The Visual D pages need to put a non-ROOT_DIR path there.

This was referenced Jan 14, 2016

Ivan Smirnov's redesign rainers/visuald#1

Closed

Ivan Smirnov's redesign dlang/visuald#57

Merged

aG0aep6G added 2 commits January 14, 2016 21:49

fix logo size in IE

fc220df

fix search dropdown in IE

6d4a4d2

aG0aep6G added 2 commits January 15, 2016 20:04

move #copyright into #content

0627616

Looks a bit nicer with the sidebar. Also helps forum.dlang.org with height calculations.

give the subnav a left border too

387922f

Also fix a subtle alignment issue that would show when expanding/collapsing an item in the phobos subnav.

aG0aep6G force-pushed the Ivan-Smirnov's-redesign branch from ba0594a to 387922f Compare January 15, 2016 20:05

replace word-spacing with padding

a14fb2f

Safari seems to have problems with word-spacing.

MartinNowak added a commit that referenced this pull request Jan 17, 2016

Merge pull request #1190 from aG0aep6G/Ivan-Smirnov's-redesign

f23f367

Ivan smirnov's redesign (2nd try)

MartinNowak merged commit f23f367 into dlang:master Jan 17, 2016

aG0aep6G deleted the Ivan-Smirnov's-redesign branch January 17, 2016 22:18

PetarKirov mentioned this pull request Jun 25, 2017

changelog: Link to all versions page in the sidebar unconditionally #1768

Merged

wilzbach mentioned this pull request Aug 11, 2017

[WIP] Refactoring stylesheets dlang/dub-registry#241

Closed

3 tasks

Uh oh!

Ivan smirnov's redesign (2nd try) #1190

Ivan smirnov's redesign (2nd try) #1190

Uh oh!

Conversation

aG0aep6G commented Jan 11, 2016

Uh oh!

andralex commented Jan 11, 2016

Uh oh!

JakobOvrum Jan 11, 2016

Choose a reason for hiding this comment

Uh oh!

MartinNowak commented Jan 12, 2016

Uh oh!

aG0aep6G commented Jan 12, 2016

Uh oh!

aG0aep6G commented Jan 12, 2016

Uh oh!

CyberShadow commented Jan 12, 2016

Uh oh!

MartinNowak commented Jan 12, 2016

Uh oh!

CyberShadow commented Jan 12, 2016

Uh oh!

MartinNowak commented Jan 13, 2016

Uh oh!

CyberShadow Jan 13, 2016

Choose a reason for hiding this comment

Uh oh!

aG0aep6G Jan 13, 2016

Choose a reason for hiding this comment

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

MartinNowak commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

MartinNowak commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

aG0aep6G commented Jan 13, 2016

Uh oh!

aG0aep6G commented Jan 13, 2016

Uh oh!

aG0aep6G commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 13, 2016

Uh oh!

CyberShadow commented Jan 14, 2016

Uh oh!

aG0aep6G commented Jan 14, 2016

Uh oh!

aG0aep6G commented Jan 14, 2016

Uh oh!

aG0aep6G commented Jan 14, 2016

Uh oh!

andralex commented Jan 15, 2016

Uh oh!

CyberShadow commented Jan 15, 2016

Uh oh!

aG0aep6G commented Jan 15, 2016

Uh oh!

MartinNowak commented Jan 16, 2016

Uh oh!

CyberShadow commented Jan 17, 2016

Uh oh!

andralex commented Jan 17, 2016

Uh oh!

CyberShadow commented Jan 17, 2016

Uh oh!