Skip to content

Increased the size of the header and logo. #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Increased the size of the header and logo. #1227

wants to merge 1 commit into from

Conversation

nomad-software
Copy link
Contributor

I've increased the size of the D logo in the header as I feel it was a little on the small side. I've also adjusted the navigation and spacing in the header to account for the new size. It should also work fine in different sizes for mobile and desktop, etc. This is purely a CSS stylesheet change.

Preview: http://nomad.so/misc/d/dlang.org/increase-header-size/

@aG0aep6G
Copy link
Contributor

aG0aep6G commented Feb 8, 2016

I think I like the smaller one better.

@CyberShadow
Copy link
Member

Oof, no, I think this is not an improvement. It's much too big, especially on small screens. As-is, it would mark a massive decrease of usability on the forum on phones.

There is also an implementation problem - on some screen widths, the navigation bar wraps and takes two "rows".

@nomad-software
Copy link
Contributor Author

Oof, no, I think this is not an improvement. It's much too big, especially on small screens. As-is, it would mark a massive decrease of usability on the forum on phones.

Have you got an example of lack of usability on small screen devices? Also the forums are as of yet unaffected.

There is also an implementation problem - on some screen widths, the navigation bar wraps and takes two "rows".

Fixed.

Of course, I think it's an improvement and it's tested well on small devices. IMHO the logo needs to be more prominent on the site. I would like to get more opinions on this.

@JackStouffer
Copy link
Member

Sorry, I'm really not a fan of this. IMO this is a waste of precious screen space, and navigation should be less obtrusive not more.

@dnadlinger
Copy link
Member

I prefer the current version as well. The larger navigation bar looks absurdly big to me, especially so on my mobile phone.

@CyberShadow
Copy link
Member

Have you got an example of lack of usability on small screen devices?

Just go to forum.dlang.org on your phone, rotate the phone to portrait orientation, and select the horizontal-split view mode. Don't hide the navigation, the site should be usable without having to do that.

Also the forums are as of yet unaffected.

The styles of the two websites should stay in sync, so any change in dlang.org's style implies it will need to trickle down to the forum too.

@CyberShadow
Copy link
Member

I think I like the smaller one better.

Sorry, I'm really not a fan of this.

I prefer the current version as well.

Well, I think we have consensus here. Sorry.

@brad-anderson
Copy link
Member

One alternative might be to have this on the front page and the smaller one on the more content rich pages.

@nomad-software
Copy link
Contributor Author

Ok, the community has spoken but I will add one point.

We shouldn't be designing the site from a mobile point of view, especially because it's a site that will be used by developers while developing on desktop PC's. The site should scale to whatever device you are on. I personally think the logo should be bigger on desktop and this in no way affects the mobile experience as that can be a different size, etc.

Also, the comments about the forums are moot as they haven't been touched in this PR. That was going to be addressed in a later PR if this one was ok'ed.

@p0nce
Copy link
Contributor

p0nce commented Feb 10, 2016

I liked the proposal better than the current. It would be cool to have something intermediate.

@PetarKirov
Copy link
Member

+1 for something intermediate in terms of size.

@d-random-contributor
Copy link

screenshot

will be used by developers while developing

I use it for developing, but I never see the front page, it has nothing for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants