Skip to content

Upgrade hyphenate.js to 4.2.0 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2013

Conversation

brad-anderson
Copy link
Contributor

No description provided.

@andralex
Copy link
Member

@eco great, thanks. Could you please document here how you generated the file and with what options?

@brad-anderson
Copy link
Contributor Author

Just used the mergeAndPack tool they have on their website (you have to update the URL with each new version). I just keep all the settings at the default except I check the CSS3 support option:

http://hyphenator.googlecode.com/svn/tags/Version%204.2.0/mergeAndPack.html

@andralex
Copy link
Member

@eco there are a couple of options that would be great to experiment with if you have the time:

  • Define intermediate state (style.visibility of elements while they are hyphenated). Right now it's "hidden".
  • Define, when elements are hyphenated. Right now it's "wait".

The defaults are "hidden" and "wait" which may be the reason for the flickering (the page is loaded and displayed, then hidden for hyphenation, then the whole process takes place, then the page is shown. I think we should use "visible" and "progressive".

@brad-anderson
Copy link
Contributor Author

visible seems to make a perceivable improvement. I'll update this pull request with a version using that.

@brad-anderson
Copy link
Contributor Author

Ok, this should be good to go.

andralex added a commit that referenced this pull request Jul 16, 2013
@andralex andralex merged commit 11c855b into dlang:master Jul 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants