Skip to content

Added documentation for -color #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2014
Merged

Added documentation for -color #605

merged 1 commit into from
Jul 2, 2014

Conversation

lionello
Copy link
Contributor

@lionello lionello mentioned this pull request Jun 30, 2014
Merged
@lionello
Copy link
Contributor Author

PR for dmd:
dlang/dmd#3705

ghost
ghost reviewed Jun 30, 2014
View reviewed changes
dcompiler.dd
@@ -386,6 +386,10 @@ $(WINDOWS
compile only, do not link
)

$(SWITCH $(B -color),
use ANSI colors in console output
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword this a bit and make it more descriptive. Like "Emit colorized output to the console using ASCII escape control characters", or something of that sort.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows it will not use any escape control characters

@lionello
Copy link
Contributor Author

lionello commented Jul 2, 2014

The PR for DMD was merged. Please merge this one as well, if the text is fine.

@dnadlinger
Copy link
Contributor

I thought I had commented on this to suggest merging the two paragraphs earlier, but apparently that didn't quite make it through.

@dnadlinger
Copy link
Contributor

(Yes, cov also appears twice, but there the functionality at least changes, even though they probably should be merged too.)

@lionello
Copy link
Contributor Author

lionello commented Jul 2, 2014

Good point. Also fixed the missing space after $(I

dnadlinger added a commit that referenced this pull request Jul 2, 2014
@dnadlinger
Merge pull request #605 from lionello/color
476a6b7 
Added documentation for -color
@dnadlinger dnadlinger merged commit 476a6b7 into dlang:master Jul 2, 2014
@dnadlinger
Copy link
Contributor

Thanks. We should go over the page and harmonize punctuation and capitalization at some point, though.

@lionello lionello deleted the color branch July 2, 2014 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionello @dnadlinger