Skip to content

Conversation

brad-anderson
Copy link
Contributor

No description provided.

@JakobOvrum
Copy link
Contributor

LGTM

@mihails-strasuns
Copy link

How about mentioning std.typecons.scoped?

@brad-anderson
Copy link
Contributor Author

I'd prefer to keep it simple and provide only the typical solution. Wasn't there a bug with scoped not calling destructors?

@mihails-strasuns
Copy link

No idea what bug you are referring to (http://dpaste.dzfl.pl/03934e34a589)
Problem with not mentioning it is that people may think that stack-allocated classes are completely impossible and make justified complains about it. No need to go in details, just referring to Phobos docs should be enough.

@brad-anderson
Copy link
Contributor Author

Ok, that sounds fine. I just didn't want to overcomplicate it.

On Thu, Aug 21, 2014 at 2:16 PM, Михаил Страшун notifications@github.com
wrote:

No idea what bug you are referring to (http://dpaste.dzfl.pl/03934e34a589)
Problem with not mentioning it is that people may think that
stack-allocated classes are completely impossible and make justified
complains about it. No need to go in details, just referring to Phobos docs
should be enough.


Reply to this email directly or view it on GitHub
#637 (comment)
.

@brad-anderson
Copy link
Contributor Author

Ok, scoped is mentioned now. I also mentioned scope guards.

@mihails-strasuns
Copy link

LGTM

ghost pushed a commit that referenced this pull request Aug 22, 2014
Don't use deprecated scope feature in guide
@ghost ghost merged commit 3888a81 into dlang:master Aug 22, 2014
@ghost
Copy link

ghost commented Aug 22, 2014

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants