Skip to content

Use hierarchical Jump-to links #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2015
Merged

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Dec 24, 2014

https://issues.dlang.org/show_bug.cgi?id=5136

Show only top-level symbols in the main module jump-to links, with remaining symbols shown in separate jump-to lists before their respective parents.

Show non-top-level jump-to links even when inhibitQuickIndex is set.
Show all jump-to links with same background color as symbol declarations.

Note: std.typecons, std.stdio and std.container.rbtree are nice modules to test this with.

@ntrel ntrel changed the title Use hierarchical Jump-to links Use hierarchically-grouped Jump-to links Dec 24, 2014
@ntrel ntrel changed the title Use hierarchically-grouped Jump-to links Use hierarchical Jump-to links Dec 25, 2014
@ntrel ntrel mentioned this pull request Dec 30, 2014
@andralex
Copy link
Member

Urgh, my recent related PR might have messed with that. Could you look into reconciling this? FWIW I'd love to have a small arrow next to each struct/class. When clicked, the arrow shows members in a drop down. Would that be doable?

@ntrel ntrel force-pushed the jump-to-levels branch 2 times, most recently from 29ff9f3 to f927058 Compare January 2, 2015 18:24
@ntrel
Copy link
Contributor Author

ntrel commented Jan 2, 2015

Rebased on top of #740. I still need to show anchor overload links, will do tomorrow.

I'd love to have a small arrow next to each struct/class

Should be doable, I'll investigate. Alternatively we could just show the first line of nested jump to links until expanded.

@andralex
Copy link
Member

andralex commented Jan 6, 2015

This good to go?

@MartinNowak
Copy link
Member

Needs a rebase since #740 was merged.

@andralex
Copy link
Member

andralex commented Jan 7, 2015

rebase pliz

ntrel added 5 commits January 7, 2015 17:47
No other changes except expanding $(MIDDOT).
Show non-top-level jump-to links even when inhibitQuickIndex is set.
Show all jump-to links with same background color as symbol
declarations.
@ntrel
Copy link
Contributor Author

ntrel commented Jan 7, 2015

@MartinNowak I've made the getElementsByClassName('quickindex') change, and also used '' as the parent key name.

@andralex Should be good now, sorry for the delay.

andralex added a commit that referenced this pull request Jan 7, 2015
Use hierarchical Jump-to links
@andralex andralex merged commit 96879ea into dlang:master Jan 7, 2015
@andralex
Copy link
Member

andralex commented Jan 7, 2015

... and it's up!

@ntrel ntrel deleted the jump-to-levels branch January 9, 2015 13:19
@ntrel
Copy link
Contributor Author

ntrel commented Jan 9, 2015

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants