Skip to content

Much nicer jump-to anchors #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2014
Merged

Conversation

andralex
Copy link
Member

WalterBright added a commit that referenced this pull request Dec 30, 2014
@WalterBright WalterBright merged commit f2059f2 into dlang:master Dec 30, 2014
@ntrel
Copy link
Contributor

ntrel commented Dec 30, 2014

I don't understand everything this pull does - what are DDOC_CLASS_MEMBERS etc for?

I see this refactors the listAnchors function more cleanly, but it also:

  • Shows overload anchors (name.2)
  • Stops sorting case-insensitively
  • Means I'll have to rework Use hierarchical Jump-to links #726 (which is arguably more awesome than this pull AFAICT ;-))

@ntrel
Copy link
Contributor

ntrel commented Dec 30, 2014

what are DDOC_CLASS_MEMBERS etc for

OK, I think I understand, they set the nesting level, and this pull hides non-top-level symbols. BTW You can check top-level status just by checking if the anchor has a dot followed by non-digit in it (and ignoring the leading dot).

@andralex
Copy link
Member Author

@ntrel: right, and good point - that makes things easier and makes the whole nestingLevel unnecessary. Could you please make that improvement?

@ntrel
Copy link
Contributor

ntrel commented Dec 31, 2014

Sure, will do.

@quickfur
Copy link
Member

quickfur commented Jan 1, 2015

This PR has broken Phobos docs builds. If you clone a clean copy of dlang.org and phobos and build dlang.org then cd phobos; make -f posix.mak html, it will produce documentation pages with no content in phobos-prerelease. I'd revert this PR, but the github reverter seems to have trouble with this, as it appears to be conflicting with subsequent changes in the repo.

@ntrel
Copy link
Contributor

ntrel commented Jan 2, 2015

@andralex Now done in #740.

@quickfur Hopefully fixed with dlang/phobos#2835, please test.

@andralex andralex deleted the clean_anchors branch December 11, 2017 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants