Skip to content

Migrate most ad-hoc styling to the css #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2015
Merged

Conversation

andralex
Copy link
Member

A bunch of styling is currently hardcoded in the macros. This work migrates most styling into the css style file. That way, we can rely on css styling methods to improve the look and feel of the site without doing surgery on the macros.

@andralex
Copy link
Member Author

Here are all styles now available. Some are not defined in the css file. I defined the minimum that preserves the current look and feel.

class="anchor"
class="answer-nojs"
class="bigoh"
class="blue"
class="bnf notranslate"
class="book"
class="btn"
class="bugsfixed"
class="button"
class="ccode notranslate"
class="comp"
class="compNo"
class="compYes"
class="console notranslate"
class="cppcode notranslate"
class="cppcode2"
class="d_code notranslate"
class="d_code"
class="d_code2"
class="d_comment"
class="d_decl"
class="d_inlinecode donthyphenate notranslate"
class="d_inlinecode"
class="d_keyword"
class="d_param"
class="d_psymbol"
class="d_string"
class="ddoc_psymbol"
class="ddoccode notranslate"
class="description"
class="donthyphenate"
class="download"
class="download_image"
class="download_paragraph"
class="footnote"
class="gname"
class="green"
class="hyphenate"
class="key keyAuthors"
class="key keyBugs"
class="key keyExamples"
class="key keyLicense"
class="key keyParameters"
class="key keyReturns"
class="key keySection"
class="key keySeeAlso"
class="key keyStandards"
class="key keyThrows"
class="key keyVersion"
class="keyval Authors"
class="keyval Bugs"
class="keyval Examples"
class="keyval License"
class="keyval Parameters"
class="keyval Returns"
class="keyval Section"
class="keyval SeeAlso"
class="keyval Standards"
class="keyval Throws"
class="keyval Version"
class="metacode"
class="navblock"
class="nobr"
class="question"
class="quickindex"
class="red"
class="scini notranslate"
class="summary"
class="tip"
class="tocheader"
class="twitter-timeline"
class="val valAuthors"
class="val valBugs"
class="val valExamples"
class="val valLicense"
class="val valParameters"
class="val valReturns"
class="val valSeeAlso"
class="val valStandards"
class="val valThrows"
class="val valVersion"
class="val"
class="version"

WalterBright added a commit that referenced this pull request Jan 16, 2015
Migrate most ad-hoc styling to the css
@WalterBright WalterBright merged commit 09ca1fe into dlang:master Jan 16, 2015
@@ -43,6 +43,6 @@ $(P <center>$(LINK2 https://issues.dlang.org/reports.cgi?product=D&datasets=NEW&
Macros:
TITLE=The D Bug Tracker
PHP=<?php $0 ?>
BOOKTABLE = <center><table cellspacing=0 cellpadding=5 valign=top class=book><caption>$1</caption>$2</table></center>
BOOKTABLE = <center><table cellspacing=0 cellpadding=5 valign=top class="book"><caption>$1</caption>$2</table></center>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't stuff like the cellspacing, cellpadding, etc. also be moved to CSS? Or are you thinking of doing this in a 3-stage process, first introducing the CSS references, then implementing the actual CSS design, and finally stripping out last hard-coded style elements?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, my bad, didn't notice at first this was documenation, not the actual macro definition. But in any case, shouldn't it be updated to match the actual current definition?

@andralex
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants