Issue 10285 - Enum grammar documentation is incorrect #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable but @9rnsr should probably have a look at it too. |
|
|
||
| $(GNAME EnumBaseType): | ||
| $(GLINK2 declaration, Type) | ||
| $(GLINK Type) |
There was a problem hiding this comment.
This change will disconnect the link.
|
Additional advice: If you hope to create a detailed Pull Request, you can change the grammar step by step by using multiple commits. For example: 1st commit: Remove The stepped commit log would be much easier to review the correctness of the PR. |
|
LGTM. |
9rnsr
added a commit
that referenced
this pull request
Jan 18, 2015
Issue 10285 - Enum grammar documentation is incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=10285
This cleans up the enum declaration grammar and makes it more closely match DMD's implementation. Some rules that consisted of a single token were removed, and a new AnonymousEnumDeclaration rule was added to ensure that the "type identifer = assignExpression" syntax cannot appear in non-anonymous or typed enums.