-
-
Notifications
You must be signed in to change notification settings - Fork 380
mobile tweaks - hide sidebars if small screen, use mobile nav to compensate #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you have a mirror somewhere? |
You can see the one page I hacked up here: resize your browser to see the differences. The mobilenav.html though
Not really, I couldn't get the site to build locally (dmd -D produced I ran out of time messing with that nonsense, so I just made the edits The mobilenav.dd page is done on blind faith entirely. |
I does not work on a mobile device. I test both on an iPhone and in the iOS simulator. |
Is it possible to make the transition smooth? Just before the twitter side bar is removed the content is very narrow, then when the side bar is removed the width of the content expands. |
Oh, BTW, Bootstrap has already solved these problems, why don't use that instead. |
I might have just picked a wrong number for the size, I guess the screen is wider than I thought. (I don't actually have a smartphone so doing that blind too.) Refresh and see how it looks now: |
Sort of, but not really - Bootstrap has size jumps too since there's a cut-off point where the media queries take effect (it uses this same style of implementation, just with a LOT more code). |
No difference. Don't you need to add something like this in the <meta name="viewport" content="width=device-width, initial-scale=1"> |
Take a look at Bootstrap site. When the right side menu disappears it looks like they're adding more margin to the main content to compensate. |
Closing this since other people have stepped up with better implementations! |
My comment here:
https://issues.dlang.org/show_bug.cgi?id=13997#c1
The sidebars make the content too narrow on a small screen, so this removes them. However, the sidebar serves a useful nav purpose, so I added a new file which you can see by clicking the logo on the small thing. idk if that's any good, but it seems better than nothing.
Also, I was not able to actually test these changes since I can't get the website to build on my box. Trying to do that wasted too much time and put me overbudget on this, I still have a lot to do tonight! But it isn't a complicated change, so I'm reasonably confident it will do what I want it to do.
whether that sucks or not is another question though.