Remove collapse of already-open menu. #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
FWIW, this turns the accordion menu into a tree-style menu, but I agree that in our case it's a good change. |
CyberShadow
added a commit
that referenced
this pull request
Jan 20, 2015
Remove collapse of already-open menu.
|
Conspiracy! :) OK, will push the new site soon. |
|
There is now a visual bug: when you expand a second submenu, the previously open one's "minus" sign changes to a "plus" sign, even though it's still expanded. |
I'll fix it. |
Which might even be a better match for displaying packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you expand one submenu and it collapses another, it can have particularly annoying results. For example, when in the standard library docs, and you want to expand multiple sections (std and core), you cannot. In addition, the following sequence is quite annoying:
So when you expand std, it has many entries, scrolling core off the screen. You must scroll down to reach the core menu. As soon as you open core, it collapses std. core has very few entries in it, so the overall size shrinks tremendously. This makes the menu suck itself up off the screen, and now you have to scroll up to get at the submenus.
This fix simply avoids collapsing the already-open menu.