Skip to content

Conversation

JinShil
Copy link
Contributor

@JinShil JinShil commented Jan 24, 2015

no_std

@andralex
Copy link
Member

I think we should move forward with this, but just to make sure I've asked around. http://forum.dlang.org/post/ma0kuu$1f08$1@digitalmars.com

@CyberShadow
Copy link
Member

@andralex If it's not too hard, please use the new "Permalink" links (by right-clicking them) to share forum URLs. http://forum.dlang.org/help#canonical

@quickfur
Copy link
Member

Yes, please!

What about std.range.* and std.container.*? IMO those should also be collapsed, i.e., std.container.* should be collapsed to a single item, expandable to array, list, rbtree, etc..

@andralex
Copy link
Member

looks like this is good to go. please rebase

@JinShil
Copy link
Contributor Author

JinShil commented Jan 25, 2015

I rebased, but I have no idea if I did it right. It looks like everything's fine to my untrained eye, but please apply scrutiny.

LIBITEM_RECURSE2=.​$1$(LIBITEM_RECURSE2 $+)
>>>>>>> 870183cbd442b6af8e57ab2cdbab1ce0659ee586
_=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, you need to resove this merge conflict.

@JinShil
Copy link
Contributor Author

JinShil commented Jan 25, 2015

What about std.range.* and std.container.? IMO those should also be collapsed, i.e., std.container. should be collapsed to a single item, expandable to array, list, rbtree, etc..

I agree, but that looks like a non-trivial change. If I can get to it, I'll submit a separate pull request.

@CyberShadow
Copy link
Member

I agree, but that looks like a non-trivial change.

I have an idea on how to handle it.

@JinShil
Copy link
Contributor Author

JinShil commented Jan 25, 2015

Ok, I hope we're good to go now.

@CyberShadow
Copy link
Member

Please rebase, there is a merge commit in your commit list :)

git rebase -i origin/master, then change pick to fixup for every line except the first.

@CyberShadow
Copy link
Member

git rebase -i origin/master, then change pick to fixup for every line except the first.

Actually, not every commit. Leave the commits containing your changes, delete the other lines.

@JinShil
Copy link
Contributor Author

JinShil commented Jan 25, 2015

screw it! I'm making a new pull request.

@JinShil JinShil closed this Jan 25, 2015
@CyberShadow
Copy link
Member

You could have just recreated the branch...

andralex added a commit that referenced this pull request Jan 25, 2015
Redo #827: Remove first prefix from submenus in library reference
@CyberShadow
Copy link
Member

I have an idea on how to handle it.

#841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants