Skip to content

Conversation

Hackerpilot
Copy link
Contributor

$(D ds) $(GLINK_LEX StringLiteral)
$(D di) $(GLINK_LEX StringLiteral)
$(D dl) $(GLINK_LEX StringLiteral)
$(D df) $(GLINK_LEX StringLiteral)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this make sense? A floating-point string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each can have multiple operands. If an operand is a string literal, it is as if there were length operands, where length is the number of characters in the string

Though you're right that this doesn't make sense, and now that I'm reading the parser source it seems that I need to rewrite this part of the spec and also change the grammar.

@MartinNowak
Copy link
Member

How about updating Operands instead? Apparently Operand isn't yet defined anyhow.
And there is also https://github.com/D-Programming-Language/dlang.org/blob/0a92173a062697436456bb84a936ce0d0a3097f8/iasm.dd#L35.

@JinShil
Copy link
Contributor

JinShil commented Jun 26, 2015

@Hackerpilot, a follow-up to @MartinNowak 's comment?

@DmitryOlshansky
Copy link
Member

Ping @Hackerpilot

@Hackerpilot
Copy link
Contributor Author

I think that the reason was that string literals can't go in most of the places that an Operand can. I'd have to read through everything again to be sure.

@CyberShadow
Copy link
Member

@Hackerpilot @MartinNowak Is this good to go?

@Hackerpilot
Copy link
Contributor Author

I think so, I'm not sure if Martin agrees.

@andralex
Copy link
Member

I'll preemptively pull, @MartinNowak please undo (or build upon) if necessary.

andralex added a commit that referenced this pull request Nov 21, 2015
Issue 13301 - Inline ASM documentation does not allow string literals
@andralex andralex merged commit 20b34f5 into dlang:master Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants