-
-
Notifications
You must be signed in to change notification settings - Fork 380
Issue 13301 - Inline ASM documentation does not allow string literals #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
$(D ds) $(GLINK_LEX StringLiteral) | ||
$(D di) $(GLINK_LEX StringLiteral) | ||
$(D dl) $(GLINK_LEX StringLiteral) | ||
$(D df) $(GLINK_LEX StringLiteral) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this make sense? A floating-point string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each can have multiple operands. If an operand is a string literal, it is as if there were length operands, where length is the number of characters in the string
Though you're right that this doesn't make sense, and now that I'm reading the parser source it seems that I need to rewrite this part of the spec and also change the grammar.
faa9563
to
34d6b17
Compare
How about updating |
@Hackerpilot, a follow-up to @MartinNowak 's comment? |
Ping @Hackerpilot |
I think that the reason was that string literals can't go in most of the places that an |
@Hackerpilot @MartinNowak Is this good to go? |
I think so, I'm not sure if Martin agrees. |
I'll preemptively pull, @MartinNowak please undo (or build upon) if necessary. |
Issue 13301 - Inline ASM documentation does not allow string literals
https://issues.dlang.org/show_bug.cgi?id=13301