-
-
Notifications
You must be signed in to change notification settings - Fork 378
the big red bar #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the big red bar #869
Conversation
Also replaces the jquery animation for the mobile search box with CSS.
Color of the menu bar changed to a striking red. The header of the narrow (mobile) layout got the same treating. The menu bar now runs across the whole length of the content. In the wide layout, the logo and title ("D Programming Language") now reside in the top of the menu bar. This means there is no header in the wide layout anymore. This is a little unusual, but I think it puts nice focus on the content. The search box moved into the menu bar in both the wide and narrow layouts. The logo changed. "D" and moons are the same. The (planet) arc has the same angle, but is drawn wider. The borders and shiny effects have been dropped. Spacing between columns (navigation, content, news) doubled. Again putting focus on the content. The corners of the content area are sharp again to match the new look of the menu.
Walter is determined to keep the current logo, completely as-is: So I think any design which touches the logo will not be accepted. |
This looks professional. The logo fits the page design very well, both wide and narrow. But the red is very dominant (viewed wide) and D seems married to its current logo; although its button-like styling makes it difficult to use harmoniously on a website (constraints on style and layout). How does this look when the red is replaced with the same background as the tweets, and the old logo is used? The "Improve this page" and "Page wiki" buttons cause words to break when viewed narrow, maybe these should vanish when viewed this narrow. |
Looks great! |
Looks like this: I'm not sure if I like the color, but it's certainly workable.
That's the way it's on the current website, too. I didn't touch that. So if that needs fixing, it can be done independently. |
Pull request for the grey version: #876 |
I don't think the D Logo in this PR deviates much from the current logo, and I suspect Walter might be ok with it. However, the red menu is a little too much. I suggest combining elements of the gray version and this red version to find a better equilibrium. Mobile. Keep the "{D Logo} The D Programming Language" and red bar across the top, but make the menu gray. Desktop. Keep the "{D Logo} The D Programming Language" in the corner, but make the menu gray. |
I like @JinShil's version. I like the red more, but I seem to be in the minority :) IMO, the new logo is way way better. |
I took @JinShil's suggestion and ended up here: I didn't include the search box in the red, because I think it's conceptually closer to the navigation than to the logo/title. This way, the whole red is clickable as one. Also, the search function isn't all that great (it's just a glorified link to google), and I don't feel like putting even more focus on it. Also colored the border of the logo. |
I set some more |
Did not help. It is the same on iPad. |
Did some playing on safari. It appears the oddity is the width of the logo overflowing by 1 px into the border. For example, without the logo enabled as the background: I'm not well-versed enough with how to fix this. I noted that if I change the width like so: div#top, div#navigation, div#header, span#d-language-mobilehelper, a#d-language
{
display: block;
width: 224.5px;
} It seems to look right. 224px is what was calculated for 16em. I added a .5 and it seems to fix the issue, but I have no idea how finicky it is. |
Hm... seems to have caused a different problem (this doesn't look as noticeable to me): On the right edge, there is a 1 pixel red line outside the border now. Note that this screenshot was taken on my retina screen, which is why it's bigger than the others. I'm not at work, so my secondary non-retina monitor is not available to test with. |
To be honest, I think these slight 1 pixel errors on one browser are not worth holding back this change to me. |
This looks really good, I'm fine with the gray-oldlogo or the gray-newlogo variant. |
I really like grey-oldlogo. grey-newlogo seems a bit abrupt to me. We should probably go forward with grey-oldlogo, since everyone (incl. Andrei) seems to like it, and it doesn't go against Walter's veto. |
Agreed, let's go on with #876. |
Includes #867.
See the second commit, the big red bar, for a detailed summary of what's changing exactly, and some rationale.
This changes/adapts the logo. But it should be trivial to use the current one instead, if the logo change is not acceptable.
Live version: http://ag0aep6g-dlang.rhcloud.com/ (If you've visited this before, you may have to clear your cache to see the proper logo color.)
Going to make a forum thread about this PR.
Changes since the last incarnation of this (which was discussed in the forum):
Screenshots
wide:

narrow:

narrow with menu:
