Skip to content

increase max-widths #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

increase max-widths #886

wants to merge 1 commit into from

Conversation

aG0aep6G
Copy link
Contributor

@aG0aep6G aG0aep6G commented Feb 3, 2015

'The big grey bar' made the menu and the inter-column spacing wider, and
I'd forgotten to update these.

Both get 4.5em more for margin-left: 18em now, 13.5em before.

Hiding #news gets an additional 1em for margin-right: 21em now, 20em
before.

'The big grey bar' made the menu and the inter-column spacing wider, and
I'd forgotten to update these.

Both get 4.5em more for margin-left: 18em now, 13.5em before.

Hiding #news gets an additional 1em for margin-right: 21em now, 20em
before.
@andralex
Copy link
Member

andralex commented Feb 4, 2015

So what's the effect of this? Screenshots?

@CyberShadow
Copy link
Member

Do we need this? 1112px is wider than my usual browser viewport, and I think it looks fine right now.

@aG0aep6G
Copy link
Contributor Author

aG0aep6G commented Feb 4, 2015

So what's the effect of this? Screenshots?

This is all about how wide the page is, or more specifically how wide the content area is, just before the layout changes kick in. Comparative screenshots below.

Do we need this? 1112px is wider than my usual browser viewport, and I think it looks fine right now.

Nick Sabalausky complained about it in the forum, reminding me that I didn't update the max-widths. Here I just did the math so that #content has the same widths as before 'the big grey bar' when the switches occur.

I think the one that hides the menu can use the bump, especially on phobos pages where indentations, tables, and code snippets need horizontal space.

The one that hides #news seems to be less of an issue to me, because it only affects the home page, and there's nothing that really needs more space. On the other hand, the difference isn't that big. Unless a viewport width between 1025px and 1112px is common, we could get away with dropping #news earlier than before.

Just wide enough that #news is not hidden

Before:
screen shot 2015-02-04 at 15 42 35
After:
screen shot 2015-02-04 at 15 47 00

Just wide enough that the menu is not hidden (std.array)

By the way, we should disable hyphenation in code snippets.
Before:
screen shot 2015-02-04 at 16 11 24
After:
screen shot 2015-02-04 at 16 11 28

@andralex
Copy link
Member

andralex commented Feb 7, 2015

@CyberShadow what do you think?

@CyberShadow
Copy link
Member

I can't judge completely objectively because I have a small conflict of interest. Merge this if you think the text in the first screenshot is too narrow (although it will be more narrow still on small-screen devices).

@MartinNowak
Copy link
Member

News is important on the main page, and this won't change the docs, so let's not do it, even though the content is indeed very narrow on my screen.
before:
before
after:
after

@aG0aep6G aG0aep6G deleted the max-widths branch August 23, 2015 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants