Skip to content

don't set 'background' without setting 'color' too #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2015

Conversation

aG0aep6G
Copy link
Contributor

@aG0aep6G aG0aep6G commented Feb 3, 2015

No description provided.

@Orvid
Copy link
Contributor

Orvid commented Feb 3, 2015

This would explicitly set the text color to black, is that what it currently is?

Personally, I don't think this is needed, as the only reason I can think of that it would be needed is if a user has a custom CSS file that sets the default text color to something other than black. (As far as I know, the major browser's all default to black text)

@aG0aep6G
Copy link
Contributor Author

aG0aep6G commented Feb 3, 2015

Forgot to mention: Nick Sabalausky complained about this.

This would explicitly set the text color to black, is that what it currently is?

If no user stylesheet interferes, it inherits from and that's black, yes.

Personally, I don't think this is needed, as the only reason I can think of that it would be needed is if a user has a custom CSS file that sets the default text color to something other than black.

You just gave the reason why it's needed. A user stylesheet can set a background/color pair for . If we set only one of them, it may end up being white/white for example.

@Orvid
Copy link
Contributor

Orvid commented Feb 3, 2015

Ah, alright, I'd failed to think of the probability of them styling all <input> by default, which isn't an unreasonable thing for someone to do. With that in mind, I do agree that this is a needed change.

@Hackerpilot
Copy link
Member

Users of dark themes thank you.

@andralex
Copy link
Member

andralex commented Feb 4, 2015

screenshots pliz

@CyberShadow
Copy link
Member

This change will be invisible to almost all users, and will fix things for the remaining ones. Thanks.

CyberShadow added a commit that referenced this pull request Feb 4, 2015
don't set 'background' without setting 'color' too
@CyberShadow CyberShadow merged commit 6bf7571 into dlang:master Feb 4, 2015
@aG0aep6G aG0aep6G deleted the searchbox-color branch February 4, 2015 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants