Skip to content

Conversation

aG0aep6G
Copy link
Contributor

This way changes in druntime/phobos are properly picked up when building
dlang.org. When druntime/phobos haven't changed, their make just does
nothing.

This way changes in druntime/phobos are properly picked up when building
dlang.org. When druntime/phobos haven't changed, their make just does
nothing.
@CyberShadow
Copy link
Member

I think this is not needed, at least for Druntime?

When I run make again after a build of dlang.org, in the output I see:

make -C ../druntime -f posix.mak MODEL=64 DMD=../dmd/src/dmd OS=linux
make[1]: Entering directory `/home/dlang/d/druntime'
make[1]: Nothing to be done for `target'.
make[1]: Leaving directory `/home/dlang/d/druntime'
Your branch is up-to-date with 'origin/master'.
Already on 'master'
Already up-to-date.

@aG0aep6G
Copy link
Contributor Author

Huh, I'm seeing this:

$ make -f posix.mak druntime-release druntime-prerelease phobos-release phobos-prerelease
From https://github.com/D-Programming-Language/dmd
 * branch            HEAD       -> FETCH_HEAD
Current release: 2.067.1
make: Nothing to be done for 'druntime-release'.
make: Nothing to be done for 'druntime-prerelease'.
make: Nothing to be done for 'phobos-release'.
make: Nothing to be done for 'phobos-prerelease'.

Could your output be from apidocs-release/apidocs-prerelease? I'm having trouble building those, so I can't check.

@CyberShadow
Copy link
Member

Probably, I'm just running make -f posix.mak.

CyberShadow added a commit that referenced this pull request Jun 15, 2015
…d-phobos

always call make on druntime and phobos
@CyberShadow CyberShadow merged commit 3a708dd into dlang:master Jun 15, 2015
@aG0aep6G aG0aep6G deleted the always-call-make-on-druntime-and-phobos branch August 23, 2015 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants