This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Mark exception class constructors as @nogc #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, it looks like this fails on some tests with undefined references for strange reasons. I have no idea why, I'll leave that to others with more druntime experience to point out why. |
|
You'll have to add the change to object.di aswell. |
|
@rainers Thanks! I was just talking to someone in IRC and he noticed the same thing. I've updated that now. |
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
Apr 18, 2015
Mark exception class constructors as @nogc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception class constructors do not themselves allocate any memory in the garbage collector, so they can be marked as @nogc. This enables the exception constructors to be used with custom allocators in the future in @nogc code.
I admit that this change was so trivial I just did it directly through GitHub.