This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 14617 - PTHREAD_MUTEX_INITIALIZER does not work on OSX #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't think you want that initializer for the type itself, but only for PTHREAD_MUTEX_INITIALIZER. |
|
@MartinNowak why not? Then PTHREAD_MUTEX_INITIALIZER is simply pthread_mutex_t.init. In fact that's exactly what happens on Linux - zero-initialization just works. |
… and PTHREAD_ONCE_INIT.
schveiguy
force-pushed
the
pthreadmutexosx
branch
from
66104a2 to
ab78a53
Compare
|
Updated to only change |
Because it's a bad idea to deviate from the documented and standardized C behavior in a simple C header. |
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
May 25, 2015
Fix issue 14617 - PTHREAD_MUTEX_INITIALIZER does not work on OSX
|
The standard behavior is to fill with random data. We don't do that either ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an initializer to pthread_mutex_t so it is correct by default on OSX. Not sure if this will work, it failed my unittest build on OSX with a link error. I think possibly types.d is not included in the unit test build.