This repository was archived by the owner on Oct 12, 2022. It is now read-only.
fix issue 14946 - druntime coverage tests fail intermittently #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource directory must be the same as when the program was compiled. However, if you run concurrently the coverage tests for both debug and release, they would write to the same lst file. This moves the location of the lst file into the build directory.
|
see #1352 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14946
The solution is very unix specific, I'm not sure what happens on windows, but it doesn't appear to run those tests.
It's also specific to the way we construct the ROOT directory, but I'm not sure of a good way to do that from ROOT itself. This at least gets the job done.
I'd much rather see a good solution to this involving direction of the runtime on where to write the coverage data.