Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

MartinNowak
Copy link
Member

  • fixes make CC=/path/to/cc
  • fixes Issue 15012

Issue 15012 – Druntime Makefile whitelists compilers

@MartinNowak
Copy link
Member Author

ping @CyberShadow

@CyberShadow
Copy link
Member

Thanks Martin. But why is the whitelisting needed in the first place? It doesn't strike me as good practice, anyone can come up with a new compiler or wrapper with gcc-compatible command-line parameters. The "command-line-compatible wrapper" naming convention also seems to have the opposite naming scheme, e.g. clang-cl is clang's cl.exe-compatible wrapper.

- allows to use compiler wrappers
- fixes make CC=/path/to/cc
- fixes Issue 15012
- still can be overriden with make CFLAGS=
@MartinNowak
Copy link
Member Author

You're right, let's remove this. It's still possible to override CFLAGS if necessary.

@ibuclaw
Copy link
Member

ibuclaw commented Sep 6, 2015

Pet peeve question, why -O3? This is an optimisation flag that has been proven in the past to do aggressive loop unrolling and inlining that makes the program no longer fit in the instruction cache, producing worse code than what is done with -O2.

Maybe someone should do some fact-finding with benchmarks... :-)

@MartinNowak
Copy link
Member Author

Well there isn't any performance sensitive C code in druntime.

@MartinNowak
Copy link
Member Author

Can we also keep the OT discussion out of this PR?

@CyberShadow
Copy link
Member

Just tested, it fixes everything for me, merging.

CyberShadow added a commit that referenced this pull request Sep 6, 2015
filter on basename of compilers
@CyberShadow CyberShadow merged commit b83f84e into dlang:master Sep 6, 2015
@CyberShadow
Copy link
Member

Oops, forgot to merge via auto-tester, but it was green on both PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants