This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix epoll_event for non-X86 architectures #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X86 is the only architecture where epoll_event is actually packed. All other architectures define epoll_event as a normal struct. See also: http://bugzilla.gdcproject.org/show_bug.cgi?id=214
|
We should really consider adding automatic struct layout tests at some point... |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Mar 6, 2016
Fix epoll_event for non-X86 architectures
|
We should also consider having a list of primary targets to support in druntime, rather than breaking builds for eg: PPC after someone has gone through the effort of porting all other parts. |
That's true, we should have a list somewhere. @redstar is maintaining the PPC port IIRC? also ping @klickverbot @kinke |
|
See #1504 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X86 is the only architecture where epoll_event is actually packed. All other architectures define epoll_event as a normal struct:
http://code.metager.de/source/search?q=__EPOLL_PACKED&path=%2Fgnu%2Fglibc%2F&project=gnu
See also: http://bugzilla.gdcproject.org/show_bug.cgi?id=214