This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 15838 Many Win32 API callback functions miss extern(Windows) #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extern (Windows) to aliases and struct fields.
|
| @@ -3869,7 +3869,7 @@ static if (_WIN32_WINNT >= 0x501) { | |||
| } | |||
| alias LVINSERTGROUPSORTED* PLVINSERTGROUPSORTED; | |||
|
|
|||
| alias int function(INT, INT, VOID*) PFNLVGROUPCOMPARE; | |||
| extern (Windows) alias int function(INT, INT, VOID*) PFNLVGROUPCOMPARE; | |||
There was a problem hiding this comment.
Shouldn't it be alias PFNLVGROUPCOMPARE = extern(Windows) int function(INT, INT, VOID*); ?
There was a problem hiding this comment.
This is OK,
and extern(Windows){ aliases ... }, too.
There was a problem hiding this comment.
Ah, old style aliases should be fixed ...?
There was a problem hiding this comment.
Yes, that'd be great as a separate commit.
There was a problem hiding this comment.
I think the change of styles should be made at all.
So, these core.sys.windows.* modules have thousands of aliases, mostly in old styles.
I misses such a skill to do efficiently :P
There was a problem hiding this comment.
Okay let's ignore them for now.
|
LGTM |
|
Auto-merge toggled on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extern (Windows) to aliases and struct fields.