Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Minimal reverting of Issue 1824 - Object not const correct #278

Merged
merged 1 commit into from
Jul 23, 2012

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Jul 18, 2012

This is an alternative pull of #277, keeping const qualifiers of TypeInfo classes.

dmd: dlang/dmd#1053
druntime: #278 (old)
phobos: dlang/phobos#702 (old)

@jmdavis
Copy link
Member

jmdavis commented Jul 22, 2012

This needs to be rebased. It can't be merged as-is.

@9rnsr
Copy link
Contributor Author

9rnsr commented Jul 22, 2012

OK. I rebased the branch, and now it can be automatically merged.

@jmdavis
Copy link
Member

jmdavis commented Jul 23, 2012

All three of these pull requests are failing the pull tester right now. Do they all have to be merged at once in order to build correctly? They seem okay from what I can tell, but I only have commit permissions for druntime and Phobos, so if all 3 need to be merged at once, someone else is going to have to do it.

@9rnsr
Copy link
Contributor Author

9rnsr commented Jul 23, 2012

All three of these pull requests are failing the pull tester right now. Do they all have to be merged at once in order to build correctly?

Yes. The three pulls require each other to avoid failing tests.

They seem okay from what I can tell, but I only have commit permissions for druntime and Phobos, so if all 3 need to be merged at once, someone else is going to have to do it.

Then, I will merge these on your behalf. OK?

@MartinNowak
Copy link
Member

The change looks OK to me too.
The const-covariant TypeInfo.toString override is also fine for now.
I haven't checked for completeness though.

Then, I will merge these on your behalf. OK?

Please do.

@andralex
Copy link
Member

Alright, this is great. Again std.xml is the remaining problem. @9rsr, please advise. Thanks!

andralex added a commit that referenced this pull request Jul 23, 2012
Minimal reverting of Issue 1824 - Object not const correct
@andralex andralex merged commit bad7afa into dlang:master Jul 23, 2012
@andralex
Copy link
Member

Done!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants