Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

move handwritten di files to src #280

Merged
merged 1 commit into from Jul 22, 2012
Merged

Conversation

MartinNowak
Copy link
Member

  • doesn't mix generated and versioned files
  • allows to delete import dir in clean target

- doesn't mix generated and versioned files
- allows to delete import dir in clean target
@9rnsr
Copy link
Contributor

9rnsr commented Jul 21, 2012

Looks good to me.
But I have a question: why holding .d extension when copying from src/* to import/* instead of renaming to .di?
I've read the original pull's discussion, but couldn't find the reason...

@jmdavis
Copy link
Member

jmdavis commented Jul 22, 2012

@9rnsr I would assume that the idea was that using .di on a file which included all of the source and hadn't stripped out anything was a misnomer. So, only files which had actually stripped stuff were marked with .di.

jmdavis added a commit that referenced this pull request Jul 22, 2012
move handwritten di files to src
@jmdavis jmdavis merged commit a877827 into dlang:master Jul 22, 2012
@jmdavis
Copy link
Member

jmdavis commented Jul 22, 2012

Merged.

@9rnsr
Copy link
Contributor

9rnsr commented Jul 22, 2012

@jmdavis OK. I can agree with your assumption.

@MartinNowak
Copy link
Member Author

why holding .d extension
I've read the original pull's discussion, but couldn't find the reason...

I asked for it because .di instead of .d would indicate some kind of processing/stripping whereas the goal of #218 was to make the full content available for inlining and CTFE.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants