Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2013

@MartinNowak
Copy link
Member

You also need a dmd pull request.

@ghost ghost closed this Mar 18, 2013
@ghost ghost reopened this Mar 18, 2013
@ghost
Copy link
Author

ghost commented Mar 18, 2013

You also need a dmd pull request.

I've refixed the pull. It's only the leading characters which are problematic and need to be replaced. Hopefully this passes the whole DMD test-suite now.

@timotheecour
Copy link
Contributor

why only leading characters?
what about :
rdmd -Idir1/../dir2 ?

@ghost
Copy link
Author

ghost commented Mar 18, 2013

I thought the Posix problem was only with leading characters?

@timotheecour
Copy link
Contributor

I don't think so : the include flag can cause problems:

rdmd -cov -Itemp/../temp test_01.d

ls
temp temp-..-temp-test_02.lst test_02.d test_01.lst

@ghost
Copy link
Author

ghost commented Mar 18, 2013

I see. Ok then I'll just replace all of these with _ and make a DMD pull to fix the tests.

@ghost ghost closed this Mar 18, 2013
redstar added a commit to ldc-developers/druntime that referenced this pull request Sep 2, 2013
@ghost
Copy link
Author

ghost commented Feb 3, 2014

I see. Ok then I'll just replace all of these with _ and make a DMD pull to fix the tests.

The problem with this is that it might break existing tools that read COV output. I'm not sure how to proceed.

@MartinNowak
Copy link
Member

Never heard of such a tool.
http://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words
We could try to normalize paths before using them as cov names.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants