This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
no default lib when making druntime.so #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that -defaultlib= will be supported in a future update to dmd, but right now this works because the autotester never builds druntime.so. |
|
DMD already supports this argument since this commit. |
| @@ -152,7 +152,7 @@ dll: override PIC:=-fPIC | |||
| dll: $(DRUNTIMESO) | |||
|
|
|||
| $(DRUNTIMESO): $(OBJS) $(SRCS) | |||
| $(DMD) -shared -of$(DRUNTIMESO) -Xfdruntime.json $(DFLAGS) $(SRCS) $(OBJS) | |||
| $(DMD) -shared -defaultlib= -of$(DRUNTIMESO) -Xfdruntime.json $(DFLAGS) $(SRCS) $(OBJS) | |||
There was a problem hiding this comment.
Because DFLAGS might contain -debug there should also be -debuglib=.
There was a problem hiding this comment.
-defaultlib= means "no default library", which also applies to the debuglib.
This was referenced Mar 25, 2013
|
Needs dmd pull dlang/dmd#1798 |
|
What dmd doesn't do (and the dmd pull request does) is turn off the -lphobos2 passed to the linker. libdruntimeso.so does not (and should not) rely on libphobos2.a. |
MartinNowak
added a commit
that referenced
this pull request
Mar 26, 2013
no default lib when making druntime.so
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because linking with druntime.a and phobos2.a is a bad idea when building druntime.so