Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

jacob-carlborg
Copy link
Contributor

Depends on dlang/dmd#2271.

template RMInfo (alias mod)
{
enum RMInfo = null;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

@MartinNowak
Copy link
Member

LGTM

@jacob-carlborg
Copy link
Contributor Author

I forgot, I had a couple of questions;

  • Should we add new functionality like this to ModuleInfo.Old?
  • Should I replace ModuleInfo.Old.reserved with the new field?
  • Is it ok I add the new field before the existing name field in the new layout?

@MartinNowak
Copy link
Member

I think we can safely dismiss the old ModuleInfo stuff, should be really old by now.

Is it ok I add the new field before the existing name field in the new layout?

That should be OK, if you used an older compiler the missing field won't change the layout.

@alexrp
Copy link
Contributor

alexrp commented Jun 30, 2013

Speaking of, can't we kill off the old minfo stuff by now?

@jacob-carlborg
Copy link
Contributor Author

Currently the field of the Old struct is used to get the size of the field to calculate offsets.

@quickfur
Copy link
Member

ping

@jacob-carlborg
Copy link
Contributor Author

@quickfur This is on hold because of the compiler part. In that pull request a long discussion started about that we should support some kind of user defined RTInfo before implementing this.

@andralex
Copy link
Member

Status of this?

@jacob-carlborg
Copy link
Contributor Author

Status of this?

See: dlang/dmd#2271 (comment).

@MartinNowak
Copy link
Member

I'll close this, see dlang/dmd#2271 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants