This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Bug 4782: core.atomic.atomicLoad broken for floating point #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complexmath
added a commit
that referenced
this pull request
Aug 29, 2011
Bug 4782: core.atomic.atomicLoad broken for floating point
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that floating point values were getting returned in integer registers, not the floating point stack. I found a really obvious-in-hindsight way to fix this one: Just pun the reference to a float/double to a pointer to int/long respectively, call atomicLoad on the int/long ptr, then pun it back and return it. Everything gets returned in the proper registers and no extra platform-specific code needs to be written.